AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
99 stars 67 forks source link

Update TP53 module to accommodate tumor purity filtering #1664

Closed sjspielman closed 1 year ago

sjspielman commented 1 year ago

Part of #1624

This PR begins the process of running TP53 with tumor purity filtered data. Since a lot of module changes had to be made to generate new results, this PR focuses only on that step. There will be a second PR that adds a final notebook to this module in order to compare these results to the original ones reported in the manuscript (those next steps are started in this branch: https://github.com/sjspielman/OpenPBTA-analysis/tree/tumor_purity-tp53-notebook).

There are a variety of changes that I made here, attempting to keep code as-is as much as possible. I created a new script run_classifier-tumor-purity-threshold.sh which runs the relevant scripts in this module to re-generate results with this filtered data. This script specifically calls (and does not call) the following for stranded data only:

This script is documented in the README and also is in CI. After running this through and generating result files that can be analyzed, I also ran the normal pipeline again to ensure notebooks are rendered from the full dataset.

I'll request review once checks pass!

sjspielman commented 1 year ago

Since I'll be out for a couple days, just wanted to note where this is heading next. This notebook is still draft-y and not part of this PR, but sharing in case anyone is curious. Link to current notebook Rmd: https://github.com/sjspielman/OpenPBTA-analysis/blob/0a3202f71a73dad7dedec6a82612e0f74edb493d/analyses/tp53_nf1_score/10-tp53-tumor-purity-threshold.Rmd HTML for download: 10-tp53-tumor-purity-threshold.nb.html.zip

Importantly, I uncovered a couple areas where we reported outdated P-values, and 1-2 other small inconsistencies in the MS we should have our eyes on.

sjspielman commented 1 year ago

This is now ready for another look!