search

AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
99 stars 67 forks source link

Update interaction Ns #1688

Closed sjspielman closed 1 year ago

sjspielman commented 1 year ago

This snuck past us for V23 too, somehow... Here I just reran the notebook, and there are some new numbers. No code change, just an HTML diff. This is needed for https://github.com/AlexsLemonade/OpenPBTA-manuscript/issues/410

Before: https://htmlpreview.github.io/?https://github.com/AlexsLemonade/OpenPBTA-analysis/blob/732d07cd2946849c6b5809e364043b390f85a2ed/analyses/interaction-plots/02-result-ns-for-manuscript.nb.html After: https://htmlpreview.github.io/?https://github.com/sjspielman/OpenPBTA-analysis/blob/interaction_numbers/analyses/interaction-plots/02-result-ns-for-manuscript.nb.html

sjspielman commented 1 year ago

@jashapiro actually hold off on reviewing - I'm going to remove you and re-request when ready. there's a couple calculations I'm now seeing in the MS that I realize we should put in this notebook also.

sjspielman commented 1 year ago

PR update - there are now some small code changes! I had to add in a TP53 calculation needed for inventorying co-occurrence numbers towards this issue: https://github.com/AlexsLemonade/OpenPBTA-manuscript/issues/410 I also removed a now-outdated comment, but did not replace it since it's not needed.

sjspielman commented 1 year ago

Note to self: Merge this after #1689 to not wreck that PR's CI progress. Edit - this is good to go when CI finished since #1689 is merged.