search

AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
99 stars 66 forks source link

Updated analysis: histology-treemap.html is broken -- probably delete it? #920

Open cansavvy opened 3 years ago

cansavvy commented 3 years ago

What analysis module should be updated and why?

sample-distribution-analyses, specifically the histology-treemap.html plot.

What changes need to be made? Please provide enough detail for another participant to make the update.

plots/histology-treemap.html shows up as a black rectangle. I'm not sure if this plot is being used other places. We may just want to get rid of it.

You can see the original comment here: https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/918#pullrequestreview-574436580

What input data should be used? Which data were used in the version being updated?

Should be as simple as getting rid of the lines in 02-multilayer-plots.R that make that plot.

Who will complete the updated analysis?

I can do this in a PR later probably.

jharenza commented 3 years ago

Agree with removing - I think we can use the pie chart as the sample distribution figure, with modifications as noted in #1144