AlexsLemonade / OpenScPCA-analysis

An open, collaborative project to analyze data from the Single-cell Pediatric Cancer Atlas (ScPCA) Portal
Other
9 stars 17 forks source link

Discussion: Module testing GHA path updates #676

Closed sjspielman closed 2 months ago

sjspielman commented 3 months ago

Two items I've noticed about triggers for module testing GHAs, using this for example:

https://github.com/AlexsLemonade/OpenScPCA-analysis/blob/c6a0a243fdaf3d1268a0789d4664044a252655fa/.github/workflows/run_doublet-detection.yml#L25-L27

1) I wondered if we want to update path to exclude Dockerfile? The reason for this is if a Dockerfile has been updated, then the environment is not up-to-date for the analysis to run successfully. That said, this only is true if the GHA is actually using the Docker image. So, perhaps this something we'd do internally: When we update GHAs to pull Docker images, we'd also update it to exclude the Dockerfile path as a trigger. (GHA path docs) 2) At once point, I had added .github/workflows/run_doublet-detection.yml into the paths field. We might consider doing this more generally and/or adding it to the template module testing GHA

jashapiro commented 2 months ago

Let's do this, yes!

Note that we will need to revert the change noted in https://github.com/AlexsLemonade/OpenScPCA-analysis/pull/746#discussion_r1742470374

As for the Docker question, if changes are only in the Dockerfile/.dockerignore, then there is not much point in rerunning the workflow whether or not the action is using Docker, so we may as well do that too.