AlexsLemonade / OpenScPCA-analysis

An open, collaborative project to analyze data from the Single-cell Pediatric Cancer Atlas (ScPCA) Portal
Other
5 stars 14 forks source link

Fix linking to use relative links #736

Closed jashapiro closed 1 month ago

jashapiro commented 1 month ago

Closes #733

It seems that the problem in #733 was not relative path symlinks being a problem in Docker, but in fact that I had introduced a bug whereby we were creating absolute path symlinks, which I would fully expect to fail when mounted in Docker images.

This should fix the issue, and does in my local testing. Because this is creating the behavior we expected, I do not think we should need any docs updates, but please do confirm that you agree, and that this fixes the issue.

You should be able to run ./download-data.py --update-symlink to fix any issues with your current data/ directory.