search

AlexsLemonade / OpenScPCA-analysis

An open, collaborative project to analyze data from the Single-cell Pediatric Cancer Atlas (ScPCA) Portal
Other
9 stars 17 forks source link

Propagate miniforge Docker changes #746

Closed jashapiro closed 2 months ago

jashapiro commented 2 months ago

Closes #743

This PR propagates changes from #744 to all Dockerfiles where conda is installed separately through miniforge, and to the docs with miniforge installation instructions for Docker. I had checked that #744 was successful by running the Run cell-type-ewings analysis module which is not yet complete, but is successfully running in the provided docker container.

I also temporarily removed the trigger for doublet-detection to run on workflow changes, just because at the moment that would run using the old docker image. Once this PR is in and the new docker image has been pushed to ECR, this change can be reverted.

jashapiro commented 2 months ago

I did wonder if you also wanted to add the "!analyses/<module name>/<Docker & .dockerignore>" lines to the hello-* module run workflow files? The only other module is metacells which isn't using Docker yet.

I thought about it, but those modules don't currently actually use the Docker images, so I wasn't as worried about it, so I decided to keep the changes more limited. But I can see it going either way, really.