AlexsLemonade / OpenScPCA-analysis

An open, collaborative project to analyze data from the Single-cell Pediatric Cancer Atlas (ScPCA) Portal
Other
5 stars 14 forks source link

initial commit #766

Closed danhtruong closed 1 week ago

danhtruong commented 1 week ago

Purpose/implementation Section

Initial commit with the readme.md.

Please link to the GitHub issue that this pull request addresses.

If applicable, you can also link to the associated GitHub Discussion. https://github.com/AlexsLemonade/OpenScPCA-analysis/issues/701

What is the goal of this pull request?

Initialize the module and add the readme.md

Briefly describe the general approach you took to achieve this goal.

Created a fork and a feature branch.

If known, do you anticipate filing additional pull requests to complete this analysis module?

Yes. I will add the analysis script.

Provide directions for reviewers

Initial commit and confirming the workflow

Is there anything that you want to discuss further?

Author checklists

Check all those that apply. Note that you may find it easier to check off these items after the pull request is actually filed.

Analysis module and review

Reproducibility checklist

jashapiro commented 1 week ago

Hi @danhtruong, thank you for your contribution!

The readme you have here looks good, but for this initial commit it would be good to have all of the module structure setup as you had it in #760. If you did run the module creation script, [create-analysis-module.py](https://github.com/AlexsLemonade/OpenScPCA-analysis/blob/main/create-analysis-module.py), you can commit all of the files that were created by it. If you did not run that script to create the analysis directory, or if you want to start fresh, I would probably do the following set of commands to set things up, run from the root of the repository (OpenScPCA-analysis/):

mv analyses/cell-type-dsrct analyses/cell-type-dsrct_orig
 ./create-analysis-module.py cell-type-dsrct --use-renv
mv analyses/cell-type-dsrct_orig/README.md analyses/cell-type-dsrct/README.md

Then you should be able to add and commit all of the files that the script created within analyses/cell-type-dsrct to this branch, as well as the skeleton workflow files that were created in .github/workflows.

Let me know if you have any questions about that process!