AlexsLemonade / refinebio-examples

Example workflows for refine.bio data
https://www.refine.bio
Other
11 stars 5 forks source link

ORA upset plot is not saved, only enrich plot 2x! #393

Closed cansavvy closed 3 years ago

cansavvy commented 3 years ago

Background

@envest identified this in the RNA-seq version but it will need to be fixed in the microarray version too. https://github.com/AlexsLemonade/refinebio-examples/pull/381#discussion_r533544500

Problem

The upset plot is not saved thought it looks like it's being saved! It's actually the enrich_plot twice! Whoops.

What potential "gotchas" do we know of?

Change needs to occur in both staging and master. Depending on timing, this might be a hotfix or might be able to be slid in with #391 or #390 or by itself

cansavvy commented 3 years ago

This was addressed in #394