AlexsLemonade / refinebio-examples

Example workflows for refine.bio data
https://www.refine.bio
Other
10 stars 5 forks source link

449 check client urls #460

Closed davidsmejia closed 2 years ago

davidsmejia commented 2 years ago

Same as before, but will merge after the new homepage changes are up.

Purpose

For any subsequent PRs, their checks will fail and present a list of the missing files and ids that correspond to any would be broken link. In order to pass you can request changes on the refinebio-frontend and rerun the Check Refinebio Frontend Urls action after the updates are deployed to get a passing result.

Issue addressed

449

Gotchas the reviewer should know about

The order of PRs that should be merged would be

Remaining concerns and questions

I think logistically an improvement would be for the action to run both on master and staging prs to match against refinebio-frontend master or dev branch so staging so they could both be deployed at the same time.

davidsmejia commented 2 years ago

Task failed successfully:

Please verify that the following file(s) exist:
index.html#this-should-fail
Error: Process completed with exit code 1.