search

AlexsLemonade / refinebio-examples

Example workflows for refine.bio data
https://www.refine.bio
Other
10 stars 5 forks source link

Update github actions to use 1password #482

Closed jashapiro closed 11 months ago

jashapiro commented 11 months ago

Purpose

Update the github actions to use 1Password for secret management

Issue addressed

closes https://github.com/AlexsLemonade/AdminItems/issues/900

Gotchas the reviewer should know about

I updated a number of actions along the way here to avoid likely github warnings, though I anticipate there may be more. I will be running some tests after filing this to make sure everything is working as expected!

Remaining concerns and questions

We'll see how the testing goes!

jashapiro commented 11 months ago

I have checked this with docker build and styling workflows, and things seem to work (after some fiddling).

The remaining workflows run fully either on merge to staging or master (docker-build-push.yml), or on a PR to master(check-frontend-urls.yml), so they have not been fully tested. However, I did check the build to make sure that the hard steps (aside from pushes) run, and it was able to render pages and login to docker.

The frontend url check has fewer changes (just to meet modern GHA standards), so I don't anticipate trouble there either.

I think this is ready for review.