AlexsLemonade / refinebio-frontend

Frontend app for refine.bio

https://www.refine.bio

Other

7 stars 7 forks source link

810 download experiment #886

Closed davidsmejia closed 4 years ago

davidsmejia commented 4 years ago

Issue Number

810

Purpose/Implementation Notes

Adds some helpers for moving away from redux Adds a DownloadExperiment component Adds a composable DownloadOptionsForm component

Types of changes

What types of changes does your code introduce?

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

Downloaded experiment as a dataset, refreshed to see if the badge was correctly showing

Checklist

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Screenshots

Please attach any screenshots that illustrate these changes.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/ccdl/refinebio-frontend/qhg5rx0j8 ✅ Preview: https://refinebio-frontend-git-davidsmejia-810-download-experiment.ccdl.now.sh

arielsvn commented 4 years ago

Also, when the "Download Now" button next to the samples table is used to download, the experiment is not marked as Processing.

davidsmejia commented 4 years ago

Also, when the "Download Now" button next to the samples table is used to download, the experiment is not marked as Processing.

Yeah by design: https://user-images.githubusercontent.com/15315514/74863463-f05bec80-531b-11ea-8e23-3f242108d65f.png

dvenprasad commented 4 years ago

Hey! I looked at the preview and noticed some things were a little different from design, and wanted know what the rationale was.

1) Search result cards don't have download now buttons (maybe we talked about this? not sure)

2) Download Now Modal:

Shows option to skip QN for microarray experiments. This option is only applicable to RNA-seq samples. (Can we disable it for micoarray experiments?)
- Shows aggregate options for experiments with only one species. (Can we disable it for single species experiment?)

There were some aesthetic inconsistencies I noticed as well for the Download Now Modal

The padding on the modal is too small. It should be 40px.
The spacing between label and form field is also too small. It should be 16px.

davidsmejia commented 4 years ago

@arielsvn could you take another look at this, I was able to support the requested feature set by pulling some data management outside of the component, would love to get your thoughts on it. going to tag you for review

some things that should be working

synchronization between navigation - download from search will show tag on experiment page
updates on the same page - ie download form near samples section should update the top download bar too
synchronization between tabs - download in one tab should update state on the other tab (if its the same experiment)

dvenprasad commented 4 years ago

@arielsvn we email them the dataset. On the We're processing page(?)/state(?) of the modal, we provide a link to track progress, which opens up a new tab.