AlexsLemonade / refinebio-web

Refinebio Web
https://staging.web.refine.bio
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

90 - Add Suggested Search Term's Functionality #116

Closed nozomione closed 1 year ago

nozomione commented 1 year ago

Issue Number

90

The initial commit of this PR starts at fd5051f.

Purpose/Implementation Notes

Based on the above requirement, we'll implement this feature.

Added the query parameters to the suggested search terms on the homepage

Types of changes

New feature (non-breaking change which adds functionality)

Functional tests

List out the functional tests you've completed to verify your changes work locally.

Checklist

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
refinebio-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 7:32pm
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
refinebio-web ❌ Failed (Inspect) Apr 13, 2023 7:27pm
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
refinebio-web ❌ Failed (Inspect) Apr 13, 2023 7:27pm
dvenprasad commented 1 year ago

The pages for notch and medulloblastoma look good.

The results for GSE24528 doesn't match the accession. If it is just a an issue with the dummy data, then ignore this comment.

Another comment I had was about the presentation of results. I am not sure if this is being addressed in a separate PR. Accessions are unique, so only on result will be returned. The rest of the results are "related results" and we want to present them as such. Like so: Screenshot 2023-04-19 at 10 40 55 AM

nozomione commented 1 year ago

Item 1:

The results for GSE24528 doesn't match the accession.

Item 2:

Accessions are unique, so only on result will be returned.

Item 3:

The rest of the results are "related results" and we want to present them as such. Like so: Screenshot 2023-04-19 at 10 40 55 AM

@dvenprasad I implemented the above items in the next PR 117 - Highlight User Search Terms since there were multiple modifications made to this codebase when adding the text highlighting feature.

Please visit the next PR to see those updates or click here to review the next PR's latest UI. Thank you, Deepa!

nozomione commented 1 year ago

🗒️ As mentioned in 1:1, due to the changes made in the recent PRs (API integration for search, experiments, and samples (in progress) endpoints), I’ll be closing any PRs that are no longer relevant. Since this implementation was updated during the API integration process in the search manager, I am closing this PR as well.