149 - Restructure Shared Components Folders

AlexsLemonade / refinebio-web

Refinebio Web

https://staging.web.refine.bio

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

149 - Restructure Shared Components Folders #150

Closed nozomione closed 1 year ago

nozomione commented 1 year ago

Issue Number

Closing #149

The base PR was #145 (merged into dev)
The commit of this PR is 1f5d64f2e4ebe9c46fc51b2c711f9a6b4a3c9f91 and ends at c3c0fdbb57e6e5c784c9287613cb135d60643f85

Purpose/Implementation Notes

Please see the latest UI here.

Updated the shard components folders and names and fixed the imports.

Types of changes

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

List out the functional tests you've completed to verify your changes work locally.

Checklist

[x] Lint and unit tests pass locally with my changes

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
refinebio-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 14, 2023 2:34pm

nozomione commented 1 year ago

Please remove commit af05657 from this PR. This PR should only be the restructuring of the src/components folder. We should group the yarn/nextjs changes in a different PR. thank you

@davidsmejia I've set yarn's latest stable version back to v1.xx and removed the af05657267e125a56055793e0731368f97823f2d change, pls take a look, thank you!

nozomione commented 1 year ago

Please remove .yarnrc.yml and revert the changes in yarn.lock as well. Again I would like to not have anything in this PR besides what was discussed in the ticket. Thanks

Opps, sorry for the yarnrc yml! I reverted back yarn.lock to exactly match the previously closed PR #145 version (I included PATCH and MINOR releases for packages but I removed them again. We should include these releases in the future PR since they are backward compatible and fix some 🐛 etc. Please take a look, thank you!