179 - Implement useDatasetAction hook for dataset action button

AlexsLemonade / refinebio-web

Refinebio Web

https://staging.web.refine.bio

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

179 - Implement useDatasetAction hook for dataset action button #183

Closed nozomione closed 1 year ago

nozomione commented 1 year ago

Issue Number

Closing #179

Purpose/Implementation Notes

Based on the implementation details, implemented useDatasetAction hook.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
refinebio-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 6, 2023 7:21pm

davidsmejia commented 1 year ago

While looking at this. I think that another option besides renaming the functions for clarity would be decide if the value can be derived during execution of the hook, we can just export it as a value and it does not need to be a function. Either that or renaming are acceptable to me.

nozomione commented 1 year ago

@davidsmejia based on your suggestions, I've updated the method names. Please take a look at the comment on parameter names and let me know your thought on this, thank you David.

nozomione commented 1 year ago

@davidsmejia based on your feedback, I've renamed he parameters for this hook 9144adc542fdcfc7855ea0ace445a5d5c5b56421, please take a look.

The hasSameSamples (d1, d2) is an internal helper method that compares any two data objects, so I left the parameter names as they were (If you have any preferences, please let me know).