Closed nozomione closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
refinebio-web | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 30, 2023 10:52pm |
@davidsmejia After this PR review, please review PR https://github.com/AlexsLemonade/refinebio-web/pull/218 before reviewing PR https://github.com/AlexsLemonade/refinebio-web/pull/215, thank you.
🗒️ PR https://github.com/AlexsLemonade/refinebio-web/pull/218 is based on the merged PR https://github.com/AlexsLemonade/refinebio-web/pull/206 (accidentally merged into this branch (base) so re-opened, and reset that merged commit in this PR).
Issue Number
Closing #201
After this PR review, please review PR https://github.com/AlexsLemonade/refinebio-web/pull/218 before reviewing PR https://github.com/AlexsLemonade/refinebio-web/pull/215, thank you.
(🗒️ PR https://github.com/AlexsLemonade/refinebio-web/pull/218 is based on the merged PR https://github.com/AlexsLemonade/refinebio-web/pull/206 which was accidentally merged into this branch (base) so re-opened, and reset that merged commit in this PR.)
Purpose/Implementation Notes
Implemented the "Your dataset is ready for download" view for a file download. Please see the latest UI here.
To test the feature, please use the following dataset Id or use any unexpired datasets you've processed (the URL path should be
VERCEL_PREVIEW_URL/dataset/DATAET_ID
):A unexpired processed dataset Id
e8365f2e-8cc9-4fe9-9ec1-b402769efd5d
: https://refinebio-j0okpo13q-ccdl.vercel.app/dataset/e8365f2e-8cc9-4fe9-9ec1-b402769efd5dExpected behavior: The application will display the "Your dataset is ready for download!" (unexpired processed dataset) view which includes a download button and if there's no valid token, it'll asks the user to accept the terms of use. Once the user accepts the terms of use and continues to download the file, a token will be generated and saved in the user's localStorage. The user may skip the terms of use checkbox if one already exists.
(it matches the behavior of the current refine.bio)
Types of changes
Checklist