271 - Implement error handling for API resource requesets for the search results page

nozomione commented 10 months ago

Issue Number

NOTE: The changes in 10 files were simply the result of file/variable name renaming, import adjustments, and minor style changes. The env vars names were updated on Vercel (instead of _PATH, _HOST suffix is now used).

Closing #271

Purpose/Implementation Notes

Implement error handling for the search results page and render an error view based on the status code when error occurred.

Please see the latest UI here.

Types of changes

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
refinebio-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2023 11:31pm

nozomione commented 9 months ago

I think this looks good to me. My only concern is around the renaming of API_HOST and API_PATH.

Existing convention:
* `API_HOST`: The domain of our API, localhost, staging.refine.bio, refine.bio

* `API_VERSION`: The path partial of the API where API endpoints are nested.

* `API_PATH`: Root path of all API endpoints, this is the concatenated host and version.

I am sorry for the typo. I just fixed the value of the apiPath variable in sitemap.config (9c1694ceade37bdbff2e691cca2f89c461fd22b0 and previously missing the version number in the first logical OR) and this was the reason for renaming env name (to API_HOST from API_PATH).

I think removing the protocol from API_HOST would be something to be considered but I do not understand the intent behind this change in this PR.

I cleaned up the declaration of STAGE_API_PATH and STAGE_API_VERSION variables from the docker-compose.env file (051589656bc0c69b881fc3da88b89b9370075f9b) since currently we are not using them to compose docker container. But I kept the protocol (https , since it's constant unless a new protocol is introduced) and was added in all env variables in Vercel.

Also I ran the deploy scripts locally since the project counts changed for sitemap etc for Vercel preview deploys (02d87b9f92cdf0ff15b48ff39c95d90cb94a149b). Thank you!

AlexsLemonade / refinebio-web