AlexsLemonade / refinebio-web

Refinebio Web
https://staging.web.refine.bio
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

QA: Anchor View samples button to samples section on experiment page #280

Open dvenprasad opened 10 months ago

dvenprasad commented 10 months ago

Context

When I click on the View Samples button, it takes me to the top of the experiment page.

Problem or idea

It should link to the samples section on the experiment page instead

Solution or next step

Tagging @davidsmejia for next steps

nozomione commented 9 months ago

Hello @dvenprasad, This behavior is the same as the current refine.bio. The data in the samples table needs to be fetched first when the experiment page loads. For this, it displays a loading spinner animation when a user enters the page.

Do you want to add an auto-scroll-down to the samples table section after the data has finished loading? Please let me know!

dvenprasad commented 8 months ago

What are the loading times like? If it's less than a few seconds, it's okay to directly go to the samples table and show the spinner as the data loads.

It's more important to take users where the button says it's going to take them (i.e., the samples) than to avoid users having to see the loading spinner.

nozomione commented 8 months ago

Yes, it typically doesn't take more than a few seconds! The UI renders a loading spinner while loading the page (initially empty). The data in the submitter supplied information section and sample table section are fetched using different endpoints, with the latter usually takes longer than the top section. For the data in the sample table, once its data is successfully fetched, the page renders the full table UI (e.g., filled the table with fetched data which determines the width/height of the table, otherwise empty) and it will be auto-scrolled to the top of the page (when accessed using the view samples button) in a filed PR.