279 - QA: FIlter Rename Rna-seq to RNA-seq

[nozomione]

Issue Number

Closing #279

Purpose/Implementation Notes

Rename the Rna-seqname to be RNA-seq in UI.

@dvenprasad Please see the latest UI here.

Types of changes

What types of changes does your code introduce?

• Bugfix (non-breaking change which fixes an issue)

Functional tests

List out the functional tests you've completed to verify your changes work locally.

Checklist

• [x] Lint and unit tests pass locally with my changes
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added necessary documentation (if appropriate)
• [ ] Any dependent changes have been merged and published in downstream modules

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
refinebio-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2023 8:25pm

[nozomione]

I'd like to see some changes before we merge this:

* move the `getFormattedTechnologyNames` to `helpers/formatTechnologyName`

* remove the nested ternary operator here and handle this by either:

  * test for default case first ie. `!['platform', 'technology'].includes(filterOption) and then short circuit for the specific special cases
  * alternatively, move this logic to a function at the top of the component that takes `filterOption` and `option`

Additionally, it looks like helpers/formatPlatformName correctly falls back to the passed in value so we can remove the || option[0] fall back.

Looking at helpers/formatPlatformName, you could further clean it up by setting the default value to an empty string and removing that first check but that change doesnt need to occur in this PR.

Thank you for the idea💡!

I made the following adjustments:

• moved the getFormattedTechnologyNames to helpers/formatTechnologyName
• added the new helpers/formatFilterNames which is responsible for formatting all the filter names for UI
  • defined the constants in config/options for the filter option names that need to be formatted
• used thehelpers/formatFilterNames in the SearchFilter component and cleaned up the ternary operators for filter names

Ready for another look, thank you!