AlexsLemonade / refinebio-web

Refinebio Web
https://staging.web.refine.bio
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

223 - Integrate Github API to the request data form for filing issues in refinebio repo #301

Closed nozomione closed 3 weeks ago

nozomione commented 9 months ago

Issue Number

Closing #223

Purpose/Implementation Notes


Integrated the Github API to the request data form for creating an issue in refinebio repo:

Via Request Search Data Form When a user makes a data request, the application redirects to the homepage and displays a notification banner based on the request status (Error = GitHub and/or HubSpot failed, Success = both successful).

Success banner:

Screenshot 2023-12-11 at 12 59 23 PM

Error banner (also the failed data request will be posted in Slack CCDL channel):

Screenshot 2023-12-11 at 1 09 35 PM

Via Request Experiment Data Form If the data request was successful, the application marks the experiment as requested in the search card, otherwise the failed data request will be posted in Slack CCDL channel:

Screenshot 2023-12-11 at 1 13 59 PM

Types of changes

Checklist

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
refinebio-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 4:54pm
nozomione commented 1 month ago

@davidsmejia I've made some adjustments to this PR based on the latest updates in #300.

I've also resolved the parsing error. Please review the following commit:

Thank you David!

nozomione commented 1 month ago

@davidsmejia based on 1:1 feedback, I've adjusted the codebase (pls see commit at 79daaf0b2d8ccf72b670a5485d21f7fafaf5b670), thank you David!

(NOTE: I added the return statement to the end of api/data-requests just to prevent the eslint[consistent-return](https://eslint.org/docs/rules/consistent-return) warning.)

🗒️ This PR was previously approved, but I accidentally re-requested it after applying the updates mentioned above (it received the green light to merge following those changes in 1:1 meeting). Additionally, I’ve merged the recent docker-compose.env change (#296), so I’m proceeding to merge this into dev now. Thank you!