GA implementation review - Githubissues

AlexsLemonade / refinebio-web

Refinebio Web

https://staging.web.refine.bio

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

GA implementation review #338

Closed davidsmejia closed 1 week ago

davidsmejia commented 5 months ago

Context

I was reviewing the open GA issues and wanted to comment on more than one of them so I am opening this issue to ensure that these notes are addressed in each of them. Note this is not the entire review and each PR may have their own changes or explanations requested.

Problem or idea

We should ensure that the current GA PRs adhere to the following:

No static strings or values are defined outside of the function.
No data is pre-formatted before passing to a gtag.specificTrackingEventName function.
Every tracked metric will have a unique function. Data will be unformatted and be mutated in the function.

If two or more functions are very similar but do not track the same event, write functionality that can be shared between them but distinguish them by their function name.

Solution or next step

Ensure all open PRs related to GA adhere to the above principles

davidsmejia commented 5 months ago

Lets start with the first 5 start with the oldest and I will review those and we can move forward from there.

nozomione commented 5 months ago

Epic: GA4 Integration

This issue is to revise the following PRs for the GA custom events.

Step 1: Refactor the gtag script and adjust implementation of the first 5 PRs in chronological order for code review:

[x] https://github.com/AlexsLemonade/refinebio-web/pull/321 (this is Gtag custom event script that is used in PRs below)
- [x] https://github.com/AlexsLemonade/refinebio-web/pull/322
- [x] https://github.com/AlexsLemonade/refinebio-web/pull/323
- [x] https://github.com/AlexsLemonade/refinebio-web/pull/324
- [x] https://github.com/AlexsLemonade/refinebio-web/pull/325
- [x] https://github.com/AlexsLemonade/refinebio-web/pull/326
- [x] 🔔 David via Slack

Step 2: Once the 1st step is completed, refactor the gtag script for the remaining PR:

[x] https://github.com/AlexsLemonade/refinebio-web/pull/321 (Gtag custom event script that is used in PR below)
- [x] https://github.com/AlexsLemonade/refinebio-web/pull/327

nozomione commented 1 week ago

Completed the items listed.