367 - Add getReadableOptions helper for options

nozomione commented 1 month ago

Issue Number

Epic: #366

Closes #367

Dependency (blocked by): #365

Purpose/Implementation Notes

I've added the getReadableOptions helper and updated the implementations for Grommet Select and ReadioButtonGroup components, as well as cleaned up config/options.

Changes include:

Added new helpers getReadableOptions and uninqueArray (for DRY)
Added new properties to config/readable and cleaned up config/options (including the removal of duplicate definitions of pageSizes and the requestDataForm)
Updated the components to use getReadableOptions

Other changes:

Added a type check to gtag.TrackLink to prevent en error (in 89dd3f386f6c262f7153f15dc1bc1acd66c0069b)

Types of changes

Bugfix (non-breaking change which fixes an issue)
Refactor (addresses code organization and design mentioned in corresponding issue)
New feature (non-breaking change which adds functionality)

Functional tests

N/A

Checklist

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots

N/A

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
refinebio-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 18, 2024 10:53pm

nozomione commented 3 weeks ago

I've included the same change to helpers/getRedable aligning with the commit be8cc329255982685aa45b387f8c254429bdc895.

Additionally, I've applied 1:1 feedback to exclude MoveToDatasetButton from using helpers/getReadableOptions👍

This PR is ready for another look, thank you David!

nozomione commented 2 weeks ago

I mistakenly referred to SearchCardFooter instead of SearchCardHeader. Apologies for the confusion! I’ve now updated SearchCardHeader to ensure the href prop properly passes the formatted string and removed the link parameter's type check in gtag.trackLink accordingly!

Now, I’m merging this PR into dev. Thank you, David! 👍

AlexsLemonade / refinebio-web