377 - Use query.type and getReadable in the compendia [type] page component - Githubissues

AlexsLemonade / refinebio-web

Refinebio Web

https://staging.web.refine.bio

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

377 - Use query.type and getReadable in the compendia [type] page component #399

Closed nozomione closed 6 days ago

nozomione commented 1 week ago

Issue Number

Epic: #366

Closes #377 (Stacked issue 2)

Base PR branch: #381

Purpose/Implementation Notes

I've updated the [type] page component and its sub-component Tabs to utilize query.type and getReadable.

Changes include:

Used the type query and cleaned up the codebase
Used getReadable to set both the title prefix and the tab title

In Tabs:

Replace query.type with the type prop for optimization
Cleaned up the handleActive method
Renamed the tabs constant to tabConfigs for clarity

Types of changes

Refactor (addresses code organization and design mentioned in corresponding issue)

Functional tests

N/A

Checklist

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots

N/A

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
refinebio-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 9:54pm