search

AlexsLemonade / refinebio

Refine.bio harmonizes petabytes of publicly available biological data into ready-to-use datasets for cancer researchers and AI/ML scientists.
https://www.refine.bio/
Other
126 stars 19 forks source link

Make LGTM Happy #1692

Open cgreene opened 4 years ago

cgreene commented 4 years ago

Context

We recently enabled LGTM for refine.bio.

Problem or idea

We have 323 issues identified by LGTM ( https://lgtm.com/projects/g/AlexsLemonade/refinebio/ ). @kurtwheeler notes that code quality measures are more effective if they start from a good place. Many (all?) of these are pretty straightforward to fix (unused imports, etc).

Solution or next step

We should make a focused effort to resolve all of these that we can so that the pressure is higher on code quality (going from 0 issue to 1 issue is a bigger mental step than 323 to 324 issues).

arielsvn commented 4 years ago

Is there any way to fix them automatically? In js with Eslint, we can fix the unused import alerts automatically. If we have to do it manually, I would lean towards making the fixes gradually.