Updates out of date vcr cassettes for sra surveyor metadata requests
Removes url creation for ncbi via ftp and uses s3 location
since the response changed from ENA I have updated the test values and removed keys that are no longer returned
this is honestly kind of weird, the dates for first published and last update are now further in the past...
some attributes (spot count, base count) are no longer on sample and only on run
NOTE: This PR introduces free-disk-space github action. This is a more aggressive cleaning up of unused files from the ubunt-latest image on which our tests are run.
There aren't any methods, that I can tell, that should be called out here.
There isn't much we can do about the sample_ena_base_count and sample_ena_spot_count being removed. For newly surveyed samples we will only be able to capture what is presented to us. The test validates that the method in which we capture the data works, and this test still captures that truthiness.
Types of changes
Bugfix (non-breaking change which fixes an issue)
Functional tests
n/a
sra surveyor tests are passing
sra downloader tests are passing
Checklist
Put an x in the boxes that apply.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
Issue Number
3283
Purpose/Implementation Notes
NOTE: This PR introduces free-disk-space github action. This is a more aggressive cleaning up of unused files from the ubunt-latest image on which our tests are run.
ENA changes information here: https://docs.google.com/document/d/1RPHmK8Pvm9UxSa21Ej3MkGoGYO9baSxwxk_dOuWWyNE
Methods
There aren't any methods, that I can tell, that should be called out here. There isn't much we can do about the
sample_ena_base_countandsample_ena_spot_countbeing removed. For newly surveyed samples we will only be able to capture what is presented to us. The test validates that the method in which we capture the data works, and this test still captures that truthiness.Types of changes
Functional tests
Checklist
Put an
xin the boxes that apply.Screenshots
n/a