AlexsLemonade / refinebio

Refine.bio harmonizes petabytes of publicly available biological data into ready-to-use datasets for cancer researchers and AI/ML scientists.
https://www.refine.bio/
Other
129 stars 19 forks source link

prevent age from being set as string, adds test #3334

Closed davidsmejia closed 1 year ago

davidsmejia commented 1 year ago

Issue Number

3333

Purpose/Implementation Notes

There was a flaw in how we assigned hamonized attributes. For every attribute but age we can set an empty string, but age must be omitted because you cannot coerce an empty string into a decimal type. This PR also adds a test for the experiment in the e2e tests that was throwing the error so we can catch similar issues earlier.

Types of changes

Functional tests

Surveyed the failing experiment in the e2e tests.

Checklist

Screenshots

n/a Please attach any screenshots that illustrate these changes.