AlexsLemonade / refinebio

Refine.bio harmonizes petabytes of publicly available biological data into ready-to-use datasets for cancer researchers and AI/ML scientists.
https://www.refine.bio/
Other
126 stars 19 forks source link

Add debug lines to e2e tests #3348

Closed davidsmejia closed 11 months ago

davidsmejia commented 11 months ago

Issue Number

n/a

Purpose/Implementation Notes

This PR adds two print statements that confirm that the test that is running, shows the correct expected amount of samples to be checked for after running the end to end tests. If you are reading this, I agree with you that this does not seem necessary. However, the test failed on staging and when I logged onto the staging server I found the correct latest code and not the line from the stacktrace of the failed assertion.

Error from test:

 Traceback (most recent call last):
  File "/usr/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
    yield
  File "/usr/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
  File "/usr/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
  File "/home/user/tests/foreman/test_end_to_end.py", line 235, in test_all_the_things
    self.process_experiments()
  File "/home/user/tests/foreman/test_end_to_end.py", line 288, in process_experiments
    self.assertEqual(Sample.objects.filter(id__in=sample_id_list).count(), 191) <---- ?!?!??!?!?!?!?!?!?!?!
  File "/usr/lib/python3.8/unittest/case.py", line 912, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.8/unittest/case.py", line 905, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: 152 != 191

Methods

n/a

Types of changes

Functional tests

List out the functional tests you've completed to verify your changes work locally.

Checklist

Screenshots

n/a