AlexsLemonade / refinebio

Refine.bio harmonizes petabytes of publicly available biological data into ready-to-use datasets for cancer researchers and AI/ML scientists.
https://www.refine.bio/
Other
126 stars 19 forks source link

TXImport Eligibility - Check if SHORT and LONG indices exist #3362

Closed davidsmejia closed 10 months ago

davidsmejia commented 10 months ago

Issue Number

N/A

Purpose/Implementation Notes

When determining if TXImport can be run on a particular experiment either as part of the Salmon job or run early via the management command run_tximport we verify that the latest trascriptome index is what that salmon job was run with.

The problem encountered prior to this PR is that if the order of transcriptome indices is different, ie SHORT was created after LONG, this function would return SHORT even though we are interested in checking if the latest LONG index matches the index used to process the quant file.

My understanding is that this is to prevent different versions of salmon from being used throughout processing, which this change would still preserve.

This PR makes the following changes:

Methods

n/a or see implementation notes

Types of changes

Functional tests

tested on staging

Checklist

Screenshots

n/a

jaclyn-taroni commented 10 months ago

Purpose/implementation section seems reasonable 👍🏻 -- I agree with this assessment:

My understanding is that this is to prevent different versions of salmon from being used throughout processing, which this change would still preserve.