Use 1Password as a secrets storage - Githubissues

AlexsLemonade / refinebio

Refine.bio harmonizes petabytes of publicly available biological data into ready-to-use datasets for cancer researchers and AI/ML scientists.

https://www.refine.bio/

Other

126 stars 19 forks source link

Use 1Password as a secrets storage #3391

Closed arkid15r closed 9 months ago

arkid15r commented 9 months ago

Issue Number

https://github.com/AlexsLemonade/refinebio/issues/3390

Purpose/Implementation Notes

Use 1Password as a secrets storage:

Unify secret names
Move SSH_PUBLIC_KEY to vars
Set GH env secrets in necessary scopes only
Add environment and release version into Sentry context

The SSH public key migration to vars required some extra IFS manipulations in deploy.sh

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules