AlexsLemonade / refinebio

Refine.bio harmonizes petabytes of publicly available biological data into ready-to-use datasets for cancer researchers and AI/ML scientists.
https://www.refine.bio/
Other
126 stars 19 forks source link

Secrets Manager Secret value not set on deploy #3406

Closed davidsmejia closed 8 months ago

davidsmejia commented 9 months ago

Context

After testing the latest dev on staging I encountered a critical failure during our deploy. From what I can tell it looks like we are not populating var.sentry_dsncorrectly during deployment.

This next comment might not be relevant but I wanted to include for completeness. This deployment was triggered via pushing the v1.45.1-dev tag. However this was encountered in a subsequent re-run of the GHA after fixing issues with the deploy box key.

Problem or idea

Output from the deploy:


Error: putting Secrets Manager Secret value: InvalidRequestException: You must provide either SecretString or SecretBinary.

  on secrets.tf line 24, in resource "aws_secretsmanager_secret_version" "sentry_dsn":
  24: resource "aws_secretsmanager_secret_version" "sentry_dsn" {

Solution or next step

arkid15r commented 8 months ago

Resolved in https://github.com/AlexsLemonade/refinebio/pull/3409