AlexsLemonade / scpca-docs

User information about ScPCA processing
https://scpca.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Update FAQ for participant IDs #203

Closed allyhawkins closed 11 months ago

allyhawkins commented 11 months ago

Closes #190

Here I updated the FAQ on why participant IDs might be missing to explain what a participant ID is. We now include a participant ID for every sample, so any language about the ID being optional has been removed.

allyhawkins commented 11 months ago

LGTM... Do we want to say anything about where these come from?

You mean that they come from the submitter_id? I thought about that, but then we didn't say that in the original FAQ, so I didn't add anything, but I can.

jashapiro commented 11 months ago

Yes, that is mostly what I meant; saying they were provided by submitters was the main point I was thinking of. I don't know that we need it, so up to you.

allyhawkins commented 11 months ago

Yes, that is mostly what I meant; saying they were provided by submitters was the main point I was thinking of. I don't know that we need it, so up to you.

I added "provided by the submitter" in https://github.com/AlexsLemonade/scpca-docs/pull/203/commits/dfc3f6262f1f73c9a154433d8e7ed3a7d543f2da