AlexsLemonade / scpca-downstream-analyses

This repository is intended to store our pipeline for marker genes analysis.
0 stars 0 forks source link

Allow for merging of SCEs by integration group #342

Closed cbethell closed 1 year ago

cbethell commented 1 year ago

Issue Addressed Closes #340

What is the purpose of these changes?

The purpose of this PR is to allow users to specify which integration group each SCE belongs to (e.g. libraries from the same disease are merged together rather than all libraries being merged together into one).

What changes did you make?

The following modifications were made to the merge-sce.R script in the data integration module:

These modifications allow users to indicate which libraries (SCEs) should be grouped together.

The example metadata file was also updated to included an integration_group column and filled in with generic values.

Any comments, concerns, or questions important for reviewers Does this PR see to adequately address #340?

Checklist

Place an x in all boxes that you have completed.

cbethell commented 1 year ago

Thanks for the review @allyhawkins! I added in that extra check and removed the additional ids from the example metadata as suggested -- let me know what you think now.