AlexsLemonade / scpca-nf

scpca-nf is the Nextflow workflow for processing Single-cell Pediatric Cancer Atlas Portal data
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Update cell type report to account for multiplexed samples #519

Closed allyhawkins closed 11 months ago

allyhawkins commented 1 year ago

Once we have made the necessary changes to the cell type report for regular single-cell/single-nuclei samples, we will want to account for displaying cell type annotations in multiplexed samples.

I'm sure there are other things that I am missing, but we should use this issue to track any changes we might want to make when accounting for multiplexed cell type annotations. Then we can break out into additional issues if necessary.

sjspielman commented 11 months ago

As discussed in DSTM -

sjspielman commented 11 months ago

One quick clarification if someone can weigh in @allyhawkins @jashapiro ?

For this -

Add warning to the top (make sure all the celltype reports get it!)

I'm assuming I meant to write here top of the cell type section of each report (vs the whole report)? Especially we already have a warning of some kind at the top of the whole thing here - https://github.com/AlexsLemonade/scpca-nf/blob/74b744b8ba978d1745df17a7834d04e451d09fae/templates/qc_report/main_qc_report.rmd#L142-L155

allyhawkins commented 11 months ago

Yes, I would add a warning to the top of the cell type section in the main report and the supplemental report.

sjspielman commented 11 months ago

Closed by #574