search

AlexsLemonade / scpca-nf

scpca-nf is the Nextflow workflow for processing Single-cell Pediatric Cancer Atlas Portal data
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Update sample_type printing logic to handle multiplex samples #677

Closed sjspielman closed 9 months ago

sjspielman commented 9 months ago

Stacked on #666 😈

Closes #676

This PR updates the logic where we print the metadata(sce)$sample_type info box at the top of the QC report. I'm filing as a Draft since I'm currently testing the code, and will request review once any bugs are squashed.

One question is the relevant placement of boxes. We currently don't have any multiplex libraries from PDX or cell line samples, but if/when we do, the info box about the sample type will be printed before the warning that the library contains multiplex samples. Do we want to move the multiplex warning to be above the sample_type info box?

sjspielman commented 9 months ago

I'm currently testing the code, and will request review once any bugs are squashed

Tested, and no bugs to squash 🎉