search

AlexsLemonade / scpca-nf

scpca-nf is the Nextflow workflow for processing Single-cell Pediatric Cancer Atlas Portal data
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Fix some merge bugs #757

Closed allyhawkins closed 4 months ago

allyhawkins commented 4 months ago

In merging the processed data for a project for the Portal, I came across a small error in the merge_sces.R script. R was complaining about calculating the sum() of a list so I just added an unlist() and that fixed that problem.

The other precautionary measure I took here is to ensure that if a processed file exists but its size is 0, it's not actually included in the merging process. I can imagine that causing problems down the line if we try to read in an empty file. I also added a warning message that should print out any libraries that are not going to be included in the object.

allyhawkins commented 4 months ago

Thanks for the suggestions @jashapiro. I went ahead and incorporated both of them, I think we do want to avoid printing out multiplexed samples in the error message.