Closed allyhawkins closed 5 months ago
The changes here look fine, but I am not approving because I want just a bit more testing/evaluation before we proceed.
The things I think we still want to do:
a test with cellassign (One small sample)
I completed this and results look mostly the same with a few differences in the assigned cell types for CellAssign, but I don't think anything to be concerned about. For reference here's both the new and old cell type report for the same sample: cell-type-reports.zip
a merge test (small, again, and I expect this to work based on openscpca-nf)
This is complete without any issues.
finally, I do want to make sure we look through these results and don't see any major changes. Looking at the QC reports between what is in prod and the recent runs should be sufficient, I would think?
I looked at the old QC reports currently present in scpca-prod
for each of the test samples and compared to the new ones. Overall, there is a difference in the number of cells filtered by 1-2 cells which is expected. There was also one library that had a few HVGs switched but the overall HVGs present didn't change. This is probably due to which cells were left after filtering and also not out of the ordinary.
The biggest differences were seen in the multiplexed library report for the numbers of cells corresponding to each sample as reported by Seurat::HTODemux
. I feel like this is probably due to some slight changes in Seurat and probably okay to not worry about, but I did want to let you know in case you have other concerns.
multiplex-reports.zip
I do think it is okay not to worry about, but we should probably make a note in the next release that cell assignments from HTODemux are likely to change. I can't find anything in changelogs about what changed, but I am not at all surprised to see that something might have.
Otherwise, everything looks fine here.
Closes #761
I did some testing of the workflow using the changes from #762 and everything ran successfully 🎉 I did not however run anything through
CellAssign
... I can do that though if we would like before closing the testing out.To do the testing I was going to create a new test profile, but we already have a
ccdl
profile that specifies a subset of run IDs to run. So rather than create a new profile I'm using the existingccdl
profile but have updated therun_ids
param to include one sample or library from each of the possible modalities - one single-cell with bulk, one CITE, one multiplexed, and one spatial. I think I got everything?