AlexsLemonade / scpca-nf

scpca-nf is the Nextflow workflow for processing Single-cell Pediatric Cancer Atlas Portal data
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Add sample metadata table to QC and cell type reports #765

Closed allyhawkins closed 2 months ago

allyhawkins commented 2 months ago

Is your feature request related to a problem? Please describe.

See https://github.com/AlexsLemonade/scpca-portal/issues/759

Describe the solution you'd like A clear and concise description of what you want to happen.

We would like to include a sample metadata table in the main QC report. This should be included along with the processing and library tables that are currently present and should include things like:

We want to include any sample metadata that is consistently collected across samples.

Additional context

We might consider adding in the ontology IDs here as well. We will also have to make sure we account for things being NA as some samples do have missing information.

allyhawkins commented 2 months ago

Just noting that we should include this same table in both the main and cell type reports.

jaclyn-taroni commented 2 months ago

I changed the title to reflect https://github.com/AlexsLemonade/scpca-nf/issues/765#issuecomment-2176490048.

allyhawkins commented 2 months ago

As I started working on this, there were two things that came up that I think could benefit from asynchronous discussion:

Here's an example of what the table would look like with multiple samples for reference:

Screenshot 2024-06-28 at 10 58 01 AM
allyhawkins commented 2 months ago

To summarize our discussion in pre-planning, we will not include ontology IDs, but may include a link to the ontology ID if it's not too big of a lift. For multiplexed samples, we are not going to provide sample information but instead a blue box indicating that no sample metadata is provided because the library has samples that have been multiplexed.

allyhawkins commented 2 months ago

Closed by #769