Closed sjspielman closed 1 year ago
Made one more change! In https://github.com/AlexsLemonade/training-specific-template/pull/133/commits/a4d16bdad4e0c10115c19b2db9e3c538c32467a0, I went ahead and did add an instructors
config variable, used only in the slack-procedures.md
file. Still, can't hurt! The formatting
does render as expected.
Edit: related to #76
Accidentally put some commits onto this branch that shouldn't have been here, hence the reversion commits! just fyi for reviewers.
I've updated/simplified this quite a bit, and I have to say I'm generally happy with where it landed!
workshop-logistics.md
, which is also given in _config.yml
for the navbar.{:toc}
!if
blocks to control certain components that should only appear for remote vs in-person.
participant-information.md
remains separate (though at the same level, no need to place it in a separate nested directory) and is brought in with {% include %}
. I thought it might be better to keep this separate for ease of future editing.
Noting this overhaul essentially obviates the need for #116!
edit - still working towards the instructor list, will formally re-request review when that's ready for a look too.
Alright, we've got an array for instructors now. I don't think the syntax is too bad! I used the symbol %-
for the for loop to avoid newlines around each printed item; see here: https://shopify.github.io/liquid/basics/whitespace/.
I am still not necessarily sold on using arrays
Same, for what it's worth, but it was definitely a less bad option than "hardcoded" string...
Noting that I served this with suggestions, and all formatting looks as expected :tada:
Stacked on #129
This PR accomplishes a couple related goals as follows:
Closes #106
I added two new config variables, both with current "null" defaults of
WORKSHOP
(which has has no effect).workshop_type
, which should either be"remote"
or"inperson"
.workshop_content
, which is one of the workshop names, shorthand (e.g."intro-r"
, etc.)I also removed the training zip variables from config while I was here; any other suggestions to clean up config would be good!
I then tackled two other items to use these new variables:
Use
workshop_type
(closes #115)In the
header_pages
in config, we now have the new fileworkshop/workshop-information.md
.This file will end up
%include%
ing eitherworkshop/workshop-information-files/workshop-structure.md
ifsite.workshop_type == "remote"
, orworkshop/workshop-information-files/participant-information.md
ifsite.workshop_type == "in-person"
.participant-information.md
file for this. I plan to write as part of overall instructions in #112 that this file should be modified as needed when setting up a in-person workshop website.For formatting reasons apparently these included files need a blank line to start, so I added a jekyll comment at the top of them as a reminder to keep it blank (html comment didn't work..I didn't investigate too much, just accepted it...).
I'll note that we'll use
workshop_type
again in #123, but I'm leaving that for a later PR.Use
workshop_content
(no separate issue)workshop-materials.md
to automatically pop up a bullet list linking to relevant modules. Less manual work later!