AlexsLemonade / training-specific-template

Template repository that can be cloned to create repo for administering a specific training workshop
https://alexslemonade.github.io/training-specific-template/
Other
0 stars 2 forks source link

Add new config variables and use them #133

Closed sjspielman closed 1 year ago

sjspielman commented 1 year ago

Stacked on #129

This PR accomplishes a couple related goals as follows:

Closes #106

I added two new config variables, both with current "null" defaults of WORKSHOP (which has has no effect).

I also removed the training zip variables from config while I was here; any other suggestions to clean up config would be good!

I then tackled two other items to use these new variables:

Use workshop_type (closes #115)

Use workshop_content (no separate issue)

sjspielman commented 1 year ago

Made one more change! In https://github.com/AlexsLemonade/training-specific-template/pull/133/commits/a4d16bdad4e0c10115c19b2db9e3c538c32467a0, I went ahead and did add an instructors config variable, used only in the slack-procedures.md file. Still, can't hurt! The formatting does render as expected.

Edit: related to #76

sjspielman commented 1 year ago

Accidentally put some commits onto this branch that shouldn't have been here, hence the reversion commits! just fyi for reviewers.

sjspielman commented 1 year ago

I've updated/simplified this quite a bit, and I have to say I'm generally happy with where it landed!

Noting this overhaul essentially obviates the need for #116!

edit - still working towards the instructor list, will formally re-request review when that's ready for a look too.

sjspielman commented 1 year ago

Alright, we've got an array for instructors now. I don't think the syntax is too bad! I used the symbol %- for the for loop to avoid newlines around each printed item; see here: https://shopify.github.io/liquid/basics/whitespace/.

sjspielman commented 1 year ago

I am still not necessarily sold on using arrays

Same, for what it's worth, but it was definitely a less bad option than "hardcoded" string...

sjspielman commented 1 year ago

Noting that I served this with suggestions, and all formatting looks as expected :tada: