Merge template refresh - Githubissues

AlexsLemonade / training-specific-template

Template repository that can be cloned to create repo for administering a specific training workshop

https://alexslemonade.github.io/training-specific-template/

Other

0 stars 2 forks source link

Merge template refresh #154

Closed sjspielman closed 11 months ago

sjspielman commented 11 months ago

Closes #117

Homestretch! This PR merges template-refresh into main. I am filing this on a Friday, so I certainly do not expect it to be reviewed or merged today, but this does feel good to file!

For review, you'll want to explore the site serving under both "remote" and "in-person" configurations.

Noting this bit from #117 -

That said, I suppose it can't entirely hurt to, before this gets merged, tag/release the current main branch and then tag as new release after merging. That can be decided later.

It is now later 🎉 ! I still think versioning is not a terrible idea, since this is a public template. Any thoughts on this from reviewers? We'd want to reflect a major bump, so we could do -

pre refresh, v0.1 (at least 0.<something>)
post refresh merge, v1.0 (that said, we might want to wait on this one until we can finalize #147)

jashapiro commented 11 months ago

It is now later 🎉 ! I still think versioning is not a terrible idea, since this is a public template. Any thoughts on this from reviewers? We'd want to reflect a major bump, so we could do -

pre refresh, v0.1 (at least 0.<something>)

post refresh merge, v1.0 (that said, we might want to wait on this one until we can finalize Add additional instructions for external workshops #147)

I think tagging by year probably makes the most sense here, rather real version numbers.

sjspielman commented 11 months ago

Before merging this, it probably makes sense to tag the previous version: I'll leave it to you exactly how to do the tags, but as I said, I would probably favor dates over semantic versions.

I do like the idea of dates, but I'm not sure about using just a year. What do you think about 2023-09 (current; or really any other previous year/month combo since 2020-03!) and 2023-10 (after merge)?

sjspielman commented 11 months ago

probably should have tagged you @jashapiro ☝️

jashapiro commented 11 months ago

Before merging this, it probably makes sense to tag the previous version: I'll leave it to you exactly how to do the tags, but as I said, I would probably favor dates over semantic versions.

I do like the idea of dates, but I'm not sure about using just a year. What do you think about 2023-09 (current; or really any other previous year/month combo since 2020-03!) and 2023-10 (after merge)?

That is fine. Maybe 2020.03 for no accidental subtraction reasons?