AlexsLemonade / training-specific-template

Template repository that can be cloned to create repo for administering a specific training workshop
https://alexslemonade.github.io/training-specific-template/
Other
0 stars 2 forks source link

Add `release_tag` to config checklist #161

Closed sjspielman closed 5 months ago

sjspielman commented 5 months ago

Does what it says! I realized this was missing from the file.

Worth noting this is the first time we're doing a workshop with the updated version of training-specific-template so there may be more of these small fixes. Please have a quick look at the config to check that nothing else is missing too - I think we're good now?

sjspielman commented 5 months ago

I think the better thing to do might be to add the docker tag to https://github.com/AlexsLemonade/training-specific-template/blob/main/setup-issue-templates/workshop-release.md?

This makes sense to me

sjspielman commented 5 months ago

@jashapiro is this about what you had in mind?

sjspielman commented 5 months ago

Could you also update the default in

@jashapiro Did you want a default of edge or similar for docker_tag?

jashapiro commented 5 months ago

Could you also update the default in

@jashapiro Did you want a default of edge or similar for docker_tag?

You could. I don't think it matters too much.

sjspielman commented 5 months ago

You could. I don't think it matters too much.

I did it for the pun. Worth it.