Alexthw46 / Eidolon-Repraised

Port of an 1.16.5 magic mod to 1.19+.
https://curseforge.com/minecraft/mc-mods/eidolon-repraised
18 stars 9 forks source link

[1.20.1][Request] Gui enhancements and compatibility #65

Open ThePiekar opened 3 months ago

ThePiekar commented 3 months ago
  1. Mana bar The placement and appearance of the current mana bar, while perfectly serviceable, could use some configuration options to possibly streamline it with the rest of the hud. My personal suggesrion would be making it optionally overlay the expirience bar, simillary to how irons spells and spellbooks do it. It seems like an obvious place, since the expirience bar itself is non critical to normal play.

  2. Enhancements to health hud effects Currently, while working perfectky in vanilla play, when combined with any stacking health bar mod (making additional health rows render as new coloured hearts on the same row instead of stacking vertically) the health hud seems to act out a little. Due to the range of stacking health mods I tested it with, I believe it's implemented nearly the same for each of them (due to how similarly they behaved) and a hopefully simple workaround (possibly enabled by a config option) could remedy any issues. Problems I noticed until now is that the chill effect moves down with stacking health going below a row threshold and soul (spirit?) Hearts acting weirdly when there are absorption hearts present.

Of course those are non critical and merely suggestions on possible future polish. I'm in no way knowledgeable enough in how modern minecraft/forge handles huds to assess how easy it would be to work out. The point of of this "issue" is more so to bring some potential enhancements into attention.

ThePiekar commented 3 months ago

I'd also like to add, that in certain mana bar orientations, the last segment uses the wrong texture (empty/full).

Alexthw46 commented 2 months ago

could you point to the health mods you tested? colourful hearts fixed on their end for chill hearts, but it seems ethereal hearts don't show up at all

ThePiekar commented 2 months ago

Sure, it's been a while so I'll redo my tests and try to provide screenshots. I'll get back to you as soon as I can, tomorrow at the earliest.