Alexthw46 / Eidolon-Repraised

Port of an 1.16.5 magic mod to 1.19+.
https://curseforge.com/minecraft/mc-mods/eidolon-repraised
18 stars 11 forks source link

Soulfire Wand projectiles not affected by Archangel's Sight on players #76

Closed TillRauch closed 3 months ago

TillRauch commented 3 months ago

Forge Version: 47.3.5 Eidolon : Repraised Version: 0.3.8.13

When having the Archangel's Sight Ring equipped (and configured to also target players) projectiles like arrows shot from a vanilla bow will be guided towards the nearest enemy player. However, the energy bolts shot from a Soulfire Wand will not target enemy players but instead fly straight ahead.

This might be intentional but I assumed since the energy bolts do target mobs they should also target players.

TillRauch commented 3 months ago

After some digging in the code I believe this is due to this function https://github.com/Alexthw46/Eidolon-Repraised/blob/37484d80d90bba3cc7fc674b913d862fb40698b3/src/main/java/elucent/eidolon/common/entity/SpellProjectileEntity.java#L53 which gets used here https://github.com/Alexthw46/Eidolon-Repraised/blob/37484d80d90bba3cc7fc674b913d862fb40698b3/src/main/java/elucent/eidolon/util/EntityUtil.java#L54 never returning true if target is a player.

I am unsure how exactly to fix this. Might also be wrong in my understanding of the code.

SiverDX commented 3 months ago

add minecraft:player to https://github.com/Alexthw46/Eidolon-Repraised/blob/1.20.1-Neo/src/generated/resources/data/eidolon/tags/entity_types/trackable.json using a datapack

TillRauch commented 3 months ago

Yeah, that makes sense. Thanks