search

AlexxIT / WebRTC

Home Assistant custom component for real-time viewing of almost any camera stream using WebRTC and other technologies.
https://github.com/AlexxIT/Blog
MIT License
1.54k stars 181 forks source link

Fix static path config for HA 2024.7+ #723

Closed hmmbob closed 2 months ago

hmmbob commented 4 months ago

Fixes #722

Needs HA 2024.7+ (but the warning is only shown on 2024.7+ as well)

Tested locally, works fine

Snuffy2 commented 4 months ago

I think you need to import StaticPathConfig from homeassistant.components.http import StaticPathConfig

hmmbob commented 4 months ago

I think you need to import StaticPathConfig from homeassistant.components.http import StaticPathConfig

Yeah, great catch. Did that when testing locally, forgot to add it here. Many thanks!

AlexxIT commented 4 months ago

Thanks. But I won't accept this because breaking previous versions. A lot of users continue to use 2023.

hmmbob commented 4 months ago

I had an idea and made it backward compatible. Dropped the hacs.json change as well.

breakthestatic commented 3 months ago

@AlexxIT, any chance this could be merged now that a backwards-compatible fix has been introduced? I tested the change locally on both a pre-2024.7 install as well as current release, 2024.8

AlexxIT commented 3 months ago

I need to test this before accepting.

AlexxIT commented 2 months ago

Thanks!

AlexxIT commented 1 month ago

https://github.com/AlexxIT/WebRTC/releases/tag/v3.6.0