Closed sourcegr closed 3 years ago
Is this issue for local links (started from /
-sign) only, right?
Is this issue for local links (started from /-sign) only, right?
I believe so.
Thanks, fixed in 0.5.10
@AlexxNB, control
is used on windows, but in order to be usable on the mac, it should check for metaKey
The modifier keys, do other stuff as well. Here is a (hopefully complete) list
alt
key saves the contents of the linkcmd
(meta) opens the link in a new windowalt
key saves the contents of the linkctrl
key opens the link in a new windowI believe you should check for any modifier and cancel handling on any of them
Also: The target
could be target="_self"
meaning that the link should be handled by the lib.
Hope this helps :)
Ok, will check all cases you wrote
I added alt
, ctrl
, shift
and meta
keys.
FYI, Ctrl+click
- open in new tab, shift+click
- open in new window.
Thank you, again
Hey Alex, great lib.
<a target="_blank" ...
should open in new windowClicking on any
<a href=....
while holding thecmd
(orctrl
in widows) should open in new window.Edit: Actually, if any modifier key is pressed while clicking on the link, then the
<a...>
should not be handled by the lib.