AlfHou / hammond

Self hosted vehicle and expense management system. Like Clarkson, but better
GNU Affero General Public License v3.0
133 stars 19 forks source link

Imperial gallons (UK) #27

Open marc115uk opened 1 year ago

marc115uk commented 1 year ago

Could we add imperial gallons for MPG as well as US gallons, 4.54609 litres per gallon as this is what's used in UK. Two options to select milage, MPG US and MPG UK

thanks

AlfHou commented 1 year ago

I'll take a look at it. Do I understand correctly that you simply want another option in the dropdown in the graph or something more?

marc115uk commented 1 year ago

Ye, another option in the drop down so the statistics graph shows in imperial mpg. Also as my comment on #28 have this info displayed in statistics even when we are adding fuel in litres Thanks

AlfHou commented 1 year ago

Hmm, maybe the best option would be to have a section in the user settings where you could choose your preferred fill up metric and your preferred fuel economy metric? This could then be persistent across sessions for each user.

marc115uk commented 1 year ago

Sounds like a perfect idea should work well 😃

alexanderfitu commented 1 year ago

As a follow up (and linked to the other issue I have logged).

When adding a fillup entry, if you change the vehicle default (in my case Imperial gallons) to Liters, it seems to mess up the graph and calculations

You may want to look into this scenario a bit further, as I think it will end up overlapping with a few other cases.