search

AlfHou / hammond

Self hosted vehicle and expense management system. Like Clarkson, but better
GNU Affero General Public License v3.0
143 stars 19 forks source link

Feature: Generic Fillup Import #48

Closed alienp4nda closed 1 year ago

alienp4nda commented 1 year ago

I would like to provide a means to import csv, maybe even json, that allows the user to select which field from their import corresponds to the Hammond field.

I believe this would help solve #46 and #42 since the users will be able to map the fields in the UI.

Screen Shot 2023-04-15 at 7 40 54 AM Screen Shot 2023-04-15 at 7 41 06 AM

AlfHou commented 1 year ago

That sounds like a great idea! Let me know if I can assist with anything :)

alienp4nda commented 1 year ago

Much appreciated, I will let you know.

alienp4nda commented 1 year ago

I've finished with the csv fillup import, as in it's functional. Would y'all mind testing with your own data?

Generic Import Branch

AlfHou commented 1 year ago

Great progress. I'm getting an error image Tried debugging a bit, and seems like the backend is only receiving '0' for most many properties. See attached file: DRIVVO_HONDA_CB400N.csv

alienp4nda commented 1 year ago

Fixed it. There was an if statement with the wrong logic. Definitely no more coding when I'm tired!

AlfHou commented 1 year ago

Work for my Drivvo files. I don't have any other files to test it on, and I don't think we can expect others to set up a dev environment to test it. I suggest you open a PR and I'll review it, and then people can rather just report bugs if they experience them. 😃

alienp4nda commented 1 year ago

Let me change some of the wording so it clearly states it's only for fillups and only csv. I'll be starting on the expense import soon.

On 4/21/23, Alf Sebastian Houge @.***> wrote:

Work for my Drivvo files. I don't have any other files to test it on, and I don't think we can expect others to set up a dev environment to test it. I suggest you open a PR and I'll review it, and then people can rather just report bugs if they experience them. 😃

-- Reply to this email directly or view it on GitHub: https://github.com/AlfHou/hammond/issues/48#issuecomment-1518221388 You are receiving this because you authored the thread.

Message ID: @.***>

-- Respectfully, Alex Hess