Alfanous-team / alfanous

Alfanous is an Arabic search engine API provides the simple and advanced search in Quran , more features and many interfaces...
http://www.alfanous.org/
GNU Affero General Public License v3.0
257 stars 89 forks source link

Keyboard view not works as well as expected #496

Closed muslih closed 6 years ago

muslih commented 6 years ago

I recently try to open the keyboard by clicking keyboard icon on search bar, and it seems not working at this moment.

screen recording 2018-05-26 at 12 24 am

cc @Alfanous-team/developers

assem-ch commented 6 years ago

@muslih thank you for reporting,

@sneetsher there is issue with closing div tags , and

tag:

https://validator.w3.org/nu/?doc=http%3A%2F%2Falfanous.org%2Ftr%2Faya%2F%3Fquery%3D%25D9%2581%25D9%2588%25D9%2584%25D9%2584%26fuzzy%3DTrue%26view%3Ddefault%26sortedby%3Dscore%26translation%3Den.transliteration%26recitation%3D14%26advanced_search_advanced_query_optionsRadios%3Dphrase

muslih commented 6 years ago

@assem-ch sometimes it works, but only once, when the keyboard closed it and open again for second times it doesn't works

assem-ch commented 6 years ago

@muslih I noticed that, when the search input is under focus it doesnt show .. ping @sneetsher

sneetsher commented 6 years ago

@assem-ch I will check it. May be my added main tag.

(off-topic: I was using vim which doesn't track HTML tags, not quite familiar tools available in mac os. Any recommendation for specific IDE for Alfanous)

assem-ch commented 6 years ago

I got a free license for jetbrains pack, so pycharm is good, I give you the license by email if you want

sneetsher commented 6 years ago

@assem-ch Could you please merge related PR and keep it open. Sync with server so user using the feature can work.

I have to get a way to validate the templates. At least, for HTML tags only. Quick review, it needs rewriting of some short parts.

Ex. an opening tag inside if & else jinja control, seen by IDE/HTML-validator as 2 opening tags.

assem-ch commented 6 years ago

@sneetsher pycharm match them well, I am using it he process django templates