Alfanous-team / alfanous

Alfanous is an Arabic search engine API provides the simple and advanced search in Quran , more features and many interfaces...
http://www.alfanous.org/
GNU Affero General Public License v3.0
251 stars 89 forks source link

migrate project to support python 3 #515

Open delassio opened 5 years ago

delassio commented 5 years ago

Salam Alaikoum,

Hello, how about making this project supporting python 3

Thanks

assem-ch commented 5 years ago

@delassio Salam, migration will cost lot of efforts so if there is no clear advantage to have python 3, it will be probably a bad idea

delassio commented 5 years ago

hello, thank you her is the motivation: "Being the last of the 2.x series, 2.7 will have an extended period of maintenance. Specifically, 2.7 will receive bugfix support until January 1, 2020. After the last release, 2.7 will receive no support." https://python3statement.org/ https://www.python.org/dev/peps/pep-0373/#update https://www.python.org/dev/peps/pep-0373/#maintenance-releases

B.R

assem-ch commented 5 years ago

@delassio the issue is in the used whoosh library included in the support folder, the project should upgraded to use the last version of whoosh, even if there will be broken features. After that it can easily updated to support python 3.

Another solution is to refactor the project to use elastic search instead of whoosh, and focus only on web.

delassio commented 5 years ago

sorry, where i can found the support folder

assem-ch commented 5 years ago

https://github.com/Alfanous-team/alfanous/tree/master/src/alfanous/Support

delassio commented 5 years ago

Hello,

so we need to upgrade whoosh from 0.3.18 to 2.7

B.R

assem-ch commented 5 years ago

@delassio Yes, that's it, even if this involve sacrificing some features

delassio commented 5 years ago

good do you have roadmap (backlog) to do that

assem-ch commented 5 years ago

@delassio first you force version to the last version of whoosh, then fix any thing that get broken, if something is changed too much, rewrite it or eliminate it (no choice)

The subtasks will rise when you force the version but for now we only can guess it