AlfiyaSiddique / TastyTrails

TastyTrails is a web application designed to explore delightful recipes from around the world. It leverages modern technologies to create an immersive culinary experience.
https://delightful-daifuku-a9f6ea.netlify.app/
GNU Affero General Public License v3.0
30 stars 86 forks source link

Loader at entry #397

Closed raj-adi00 closed 2 weeks ago

raj-adi00 commented 2 weeks ago

What does this PR do?

This PR adds loader when user clicks login and signup till backend processes and when result comes either error or success it is disabled

Now user can see loader till backend process. No new dependencies included Fixes # (issue) fixes #357

Screenshot 2024-10-30 171644 No responsive issue Screenshot 2024-10-30 171600 Loader looks something like this

How should this be tested?

Required

netlify[bot] commented 2 weeks ago

Deploy Preview for delightful-daifuku-a9f6ea ready!

Name Link
Latest commit a5136b869082703c514439bdaa1b35c4a5ffdd1f
Latest deploy log https://app.netlify.com/sites/delightful-daifuku-a9f6ea/deploys/672253f8d3b0a70008aff5b4
Deploy Preview https://deploy-preview-397--delightful-daifuku-a9f6ea.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

raj-adi00 commented 2 weeks ago

https://github.com/user-attachments/assets/de509ee9-b057-4ac4-84ab-c1ad04a22750

@AlfiyaSiddique Please review it and tell me if you want any update

AlfiyaSiddique commented 2 weeks ago

@raj-adi00 works fine but can we make it visually appealing, Maybe a white background with some relatable text, can use chatgpt for this. Find some references here: https://thegood.com/insights/loading-page-design/ Let me know if you are willing to do it, if not that's fine as well. will merge it then

raj-adi00 commented 2 weeks ago

@AlfiyaSiddique i can do it hardly it will take 10 minute. You want white background and can you specify the text that you want or any image?? "Deliciousness loading, please hold..." will it be okay

AlfiyaSiddique commented 2 weeks ago

Yeah sounds good!

raj-adi00 commented 2 weeks ago

https://github.com/user-attachments/assets/02e1e3dd-563f-42c2-ac18-470d88f569ad Is it okay text is slightly bouncing

AlfiyaSiddique commented 2 weeks ago

yeah looks good, can you add some vector images above the text if you find any good ones, else let it be

raj-adi00 commented 2 weeks ago

@AlfiyaSiddique didn't find it. If you want to update just update Loader component. Please review and merge it. Please add label

github-actions[bot] commented 2 weeks ago

🎉 Thank you @raj-adi00 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀