Alfred-KInyua / Group-Capstone

2 stars 1 forks source link

Kanban board #21

Open Alfred-KInyua opened 2 years ago

Alfred-KInyua commented 2 years ago

Link to Capstone Project repo

https://github.com/Alfred-KInyua/Group-Capstone/projects/1

This project has three developers, denoted as:

addod19 commented 2 years ago

Hi TEAM,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Required Changes ♻️

Check the comments under the review.

Screenshot from 2022-07-25 10-42-55

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Alfred-KInyua commented 2 years ago

Thanks for the review. Dane with requested changes

elmar8287 commented 2 years ago

Hi, team.

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

Required Changes ♻️

Screen Shot 2022-07-25 at 15 11 40

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, remember to tag me (@elmar8287) in your question so I can receive the notification 👍

giphy

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

keroloussamy commented 2 years ago

Hi Team,

Your project is complete! There is nothing else to say other than... Congratulations! 🎉

Cheers and Happy coding!👏👏👏