search

AlfredBeNoel / pe

0 stars 0 forks source link

Lack of sequence diagram for `find` #14

Open AlfredBeNoel opened 11 months ago

AlfredBeNoel commented 11 months ago

Screenshot 2023-11-17 at 5.29.37 PM.png

There is a lack of a sequence diagram for the find command.

nus-se-bot commented 11 months ago

Team's Response

We drew uml diagrams only in the findteam, which we think is more complex, in order to preserve the neatness of the DG, and we didn't do uml digrams for any of the features present in ab3. If we did very detailed digrams for all the commands, we'd instead become unuser friendly.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I do believe that under the UML diagrams, it should have been mentioned that the UML diagram for find is similar to findteam and this justification should have been mentioned as otherwise, the developer might not understand how the code actually works, because ultimately this is for the developers to understand the functionality of your code.